Skip to content

Speed up Arr::unique #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SmetDenis merged 1 commit into from
Jun 22, 2024
Merged

Speed up Arr::unique #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions src/Arr.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,24 @@ final class Arr
public static function unique(array $array, bool $keepKeys = false): array
{
if ($keepKeys) {
$array = \array_unique($array);
} else {
// This is faster version than the builtin array_unique().
// http://stackoverflow.com/questions/8321620/array-unique-vs-array-flip
// http://php.net/manual/en/function.array-unique.php
$array = \array_keys(\array_flip($array));
// This is faster than the builtin array_unique().
$uniqueArray = [];

foreach ($array as $key => $value) {
if (isset($uniqueArray[$value])) {
continue;
}

$uniqueArray[$value] = $key;
}

return \array_flip($uniqueArray);
}

return $array;
// This is faster version than the builtin array_unique().
// http://stackoverflow.com/questions/8321620/array-unique-vs-array-flip
// http://php.net/manual/en/function.array-unique.php
return \array_keys(\array_flip($array));
}

/**
Expand Down