Exit walsender before confirming remote flush in logical replication

[grantzhou]

--- As of 2026-01-26T14:08:39.000Z ---

Fujii Masao reviews a proposed patch for walsender immediate shutdown. He addresses log level changes, questions about comment accuracy, proposes a SIGTERM-based alternative approach, and provides extensive documentation feedback. He notes potential buffer overflow issues and suggests improvements to GUC ordering, code formatting, and comment clarity throughout the patch.

藤井雅男审查了关于walsender立即关闭的补丁提案。他讨论了日志级别更改，质疑注释的准确性，提出了基于SIGTERM的替代方法，并提供了广泛的文档反馈。他指出了潜在的缓冲区溢出问题，并建议改进GUC排序、代码格式以及补丁中的注释清晰度。

participants - 参与者:

• a.silitskiy@postgrespro.ru
• aekorotkov@gmail.com
• amit.kapila16@gmail.com
• andres@anarazel.de
• dilipbalaut@gmail.com
• horikyota.ntt@gmail.com
• htamfids@gmail.com
• kuroda.hayato@fujitsu.com
• masao.fujii@gmail.com
• michael@paquier.xyz
• osumi.takamichi@fujitsu.com
• peter.eisentraut@enterprisedb.com
• sawada.mshk@gmail.com
• smithpb2250@gmail.com
• v.davydov@postgrespro.ru