Skip to content

Let loss/preds/target output keys be configurable in LitModular#169

Merged
dxoigmn merged 3 commits intomainfrom
better_litmodular2
Jun 22, 2023
Merged

Let loss/preds/target output keys be configurable in LitModular#169
dxoigmn merged 3 commits intomainfrom
better_litmodular2

Conversation

@dxoigmn
Copy link
Member

@dxoigmn dxoigmn commented Jun 13, 2023

What does this PR do?

We hardcode the name of some output keys in LitModular. This PR changes that to make those values configurable.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • pytest
  • CUDA_VISIBLE_DEVICES=0 python -m mart experiment=CIFAR10_CNN_Adv trainer=gpu trainer.precision=16 reports 70% (21 sec/epoch).
  • CUDA_VISIBLE_DEVICES=0,1 python -m mart experiment=CIFAR10_CNN_Adv trainer=ddp trainer.precision=16 trainer.devices=2 model.optimizer.lr=0.2 trainer.max_steps=2925 datamodule.ims_per_batch=256 datamodule.world_size=2 reports 70% (14 sec/epoch).

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

@dxoigmn dxoigmn marked this pull request as ready for review June 14, 2023 00:11
@dxoigmn dxoigmn requested a review from mzweilin June 14, 2023 00:11
@dxoigmn dxoigmn mentioned this pull request Jun 14, 2023
16 tasks
Copy link
Contributor

@mzweilin mzweilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dxoigmn dxoigmn merged commit 4185b3d into main Jun 22, 2023
@dxoigmn dxoigmn deleted the better_litmodular2 branch June 22, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants