-
-
Notifications
You must be signed in to change notification settings - Fork 1k
ANCS Support #2217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ANCS Support #2217
Conversation
Currently, the notification UID, Event ID and Category are shown.
Data source is not working properly, the Characteristic and/or descriptor isn't being found correctly
Datasource seems to go off and on.
Need to iron out some things like characteristics disappearing and reappearing.
Also added constants to set lengths for the title, subtitle, and message.
…essage is in the body.
Accepting and Declining works
|
Build size and comparison to main:
|
|
For reference, closes #910 Instructions: since an encrypted connection is required before ANCS is available, you’ll need to disconnect your watch from your companion app after updating, then reconnect. You’ll get a passkey on your watch to enter into the dialog on your iPhone. After bonding, toggle off and on your iPhone’s Bluetooth, then tap InfiniTime in the list of bonded devices. Finally, you’ll get an alert asking you to allow your watch to read notifications. Click allow, and now you should start receiving notifications! Something to note: as of now, since using ANCS creates a connection through iOS directly instead of through the companion app, the app will not be able to reconnect to InfiniTime without removing the bond, which results in ANCS being disabled until the steps above are repeated. We’re working on fixing this ;) Update: this is fixed in the latest InfiniLink commit on the rebuild branch |
| NegativeAction = (1 << 4) | ||
| }; | ||
|
|
||
| struct AncsNotitfication { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
…ing but not issues so far.
|
Sigh, meant to merge instead of rebase Never again will I use the github.com buttons |
|
@Crefix notifications are still sent multiple times in some cases and the simulator build needs to be fixed |
|
@liamcharger is this with the PR that @tituscmd proposed? |
|
Also, I had a fix for the simulator build locally somewhere. But I do remember it being a simple fix. |
No, just updated from main. You can just merge that PR in your fork
Yep, just one or two lines, iirc |
While on topic, sorry for not getting to that better solution we talked about in that PR yet. It's exam season so I tend to be quite busy with school. I think for now the PR is fine as it stands since it doesn't make the watch crash anymore. If that PR makes this one more likely to be merged, I think we can bother with an even better solution later. How does that sound to you? |
|
Getting this forward sounds good. Let's improve it in the next iteration if it is still functional. |
Fix race condition in ANCS discovery by adding MaybeFinishDiscovery helper NOTE: Going to merge this for now, and I will then add the functionality I talk about [here](#19 (review))
If by this you mean notifications appear on the phone but not on the watch, I have indeed had this happen |
I see, I am trying to figure out behavior. Could you maybe note symptoms of when these 2 glitches happen next time? |
It's very difficult, if at all possible, to figure out a cause. I have yet to find any correlation at all... |
|
@cyberneel, can you gather a checkbox-list of all current issues in the main description? |
|
About these little glitches that happen with ANCS, I think the thing where one ANCS notification appears on the watch multiple times happens when that notification is summarized by Apple Intelligence. This seems like a correlation I've made over the last few weeks/months, though I can't say that's exclusively it. |
|
@mark9064 can we get a workflow approval? Trying to test something out, but I can't get an environment set up for compiling right now ;) |
|
Triggered :) |
This PR Adds support for the Apple Notification Center Service (ANCS). It shows the Title and Subtitles as "Title - Subtitle" and the message is shown in the body of the InfiniTime notification. Accepting and Declining calls also worked.
The only "issue" right now is that you have to ReConnect after the first pair for ANCS discovery to go well. Maybe there is a way in the NimBLE stack to trigger ANCS Discovery after pairing change? Also, sometimes ANCS goes dormant and then works again. I think this could either be iOS throttling or