feat: migrate FILES_HIDE_SCHEMA_DOT_ORG_DOWNLOAD_URLS to MPConfig#11482
Merged
ofahimIQSS merged 2 commits intoIQSS:developfrom May 20, 2025
Merged
Conversation
pdurbin
reviewed
May 12, 2025
Member
pdurbin
left a comment
pdurbin
left a comment
There was a problem hiding this comment.
Thanks for the PR! I left a comment.
pdurbin
added
Component: Containers
ofahimIQSS
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
…-schema-dot-org-download-urls
stevenwinship
moved this from Ready for Review ⏩
to In Review 🔎
in IQSS Dataverse Project
stevenwinship
approved these changes
May 19, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
tests passed - merging. |
github-project-automation
bot
moved this from QA ✅
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As discussed on Zulip (https://dataverse.zulipchat.com/#narrow/channel/375707-community/topic/Setting.20dataverse.2Efiles.2Ehide-schema-dot-org-download-urls/with/514143249), this PR migrates the option
dataverse.files.hide-schema-dot-org-download-urlsto MPConfig.Which issue(s) this PR closes:
Special notes for your reviewer:
/
Suggestions on how to test this:
Running the tests:
mvn test -Dtest="SchemaDotOrgExporterTest"I also tested manually by starting a Dataverse with the env variable
DATAVERSE_FILES_HIDE_SCHEMA_DOT_ORG_DOWNLOAD_URLS: "1"set, then creating a dataset, uploading a file, publishing it and checking that the schema.org export did not contain the download URL.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
/
Is there a release notes update needed for this change?:
Not sure? If you want me to add a release note, please let me know
Additional documentation:
/