Merged
Conversation
SimonCropp
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error
The resource object with key 'DateHumanize_MultipleDaysFromNow' was not found Parameter name: resourceKey(and similar) was misleading. What was happening, I believe, is that for some Slavic and other languages, that resolve to_Paucal(or others) resource and when only default culture is installed then this error is being thrown. This was happening because the default resource did not have some of the keys that were present in other locales.The solution is that default Resources.resx file should have all the keys that are present in other locales.
Also made exception more descriptive by providing the resolved key for the future.
Fixes #690