Skip to content

Fixed The resource object with key 'DateHumanize_MultipleDaysAgo' was…#1171

Merged
clairernovotny merged 1 commit intoHumanizr:mainfrom
rborosak:DateHumanize_MultipleDaysAgo_key_missing_hr
Jan 27, 2022
Merged

Fixed The resource object with key 'DateHumanize_MultipleDaysAgo' was…#1171
clairernovotny merged 1 commit intoHumanizr:mainfrom
rborosak:DateHumanize_MultipleDaysAgo_key_missing_hr

Conversation

@rborosak
Copy link
Contributor

… not found for "hr" culture

Added DateHumanize_MultipleDaysAgo_DualTrialQuadral resource key
Updated DaysAgo tests to verify the fix is valid

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

… not found for "hr" culture

Added DateHumanize_MultipleDaysAgo_DualTrialQuadral resource key
Updated DaysAgo tests to verify the fix is valid
@dnfadmin
Copy link

dnfadmin commented Jan 27, 2022

CLA assistant check
All CLA requirements met.

@clairernovotny clairernovotny merged commit 333d940 into Humanizr:main Jan 27, 2022
@rborosak
Copy link
Contributor Author

Thank you.
When can we expect a new version of a nuget package?

@rborosak rborosak deleted the DateHumanize_MultipleDaysAgo_key_missing_hr branch January 27, 2022 15:16
@clairernovotny
Copy link
Member

I was hoping to get the Spanish fixes in the next release if they'll be done soon. @ohmineer do you have any estimate of when those will be ready? I can always get another release out later too.

@ohmineer
Copy link

Hi @clairernovotny, it is almost ready...
I have already finished the code and I was trying to understand the process. I tried to rebase my branches on top of latest merge and got a conflict in I file I hadn't modified (IndianNumberToWordsConverter.cs). In any case, I think I rebased my branches properly.
Then I hit the PR button but realised I may need to update the README.md file to explain the new parameter WordForm.
Let me check it but I think I should be able to finish everything by the weekend. Is that OK for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The resource object with key 'DateHumanize_MultipleDaysAgo' was not found (Parameter 'resourceKey')

4 participants