Skip to content

fixes #1161#1164

Merged
clairernovotny merged 3 commits intoHumanizr:mainfrom
biju-ps:main
Jan 25, 2022
Merged

fixes #1161#1164
clairernovotny merged 3 commits intoHumanizr:mainfrom
biju-ps:main

Conversation

@biju-ps
Copy link
Contributor

@biju-ps biju-ps commented Jan 10, 2022

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

@dnfadmin
Copy link

dnfadmin commented Jan 10, 2022

CLA assistant check
All CLA requirements met.

@clairernovotny
Copy link
Member

clairernovotny commented Jan 20, 2022

When it comes to localization, I don't have an opinion as it's not my tongue. I'll defer to those who know the language and culture better and go with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Number to word and Indian numeral system

4 participants