Skip to content

Fix DateOnly, TimeOnly & DateTime issues in French#1150

Merged
clairernovotny merged 3 commits intoHumanizr:mainfrom
louis-z:issue-1012
Dec 28, 2021
Merged

Fix DateOnly, TimeOnly & DateTime issues in French#1150
clairernovotny merged 3 commits intoHumanizr:mainfrom
louis-z:issue-1012

Conversation

@louis-z
Copy link
Contributor

@louis-z louis-z commented Nov 28, 2021

  • Add DateToOrdinalWordsTests, TimeOnlyHumanizeTests & TimeToClockNotationTests for French culture
  • Adapt code so that tests pass

Relates to #1081
Relates to #1134 (comment)
Fixes #1012

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

@louis-z
Copy link
Contributor Author

louis-z commented Nov 28, 2021

@mr-aboutin, @aloisdg, I've tried to address some of your concerns. Let me know what you think.

- Add DateToOrdinalWordsTests, TimeOnlyHumanizeTests & TimeToClockNotationTests for French culture
- Adapt code so that tests pass
@clairernovotny clairernovotny merged commit 7492f69 into Humanizr:main Dec 28, 2021
@louis-z louis-z deleted the issue-1012 branch December 29, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DateTime.ToOrdinalWords() in French Culture incorrect

4 participants