Fixed default number format#1114
Merged
clairernovotny merged 4 commits intoHumanizr:mainfrom Oct 29, 2021
YohDeadfall:fix-default-number-format
Merged
Fixed default number format#1114clairernovotny merged 4 commits intoHumanizr:mainfrom YohDeadfall:fix-default-number-format
clairernovotny merged 4 commits intoHumanizr:mainfrom
YohDeadfall:fix-default-number-format
Conversation
Contributor
Author
|
Hello, @clairernovotny! Could you take a look at this PR and clarify its status? |
Member
|
Not entirely sure why, but it looks like there's a test failure now? |
Contributor
Author
|
Will take a look. |
YohDeadfall
commented
Oct 29, 2021
|
|
||
| [Theory] | ||
| [InlineData(19854651984, 1, TimeUnit.Second, null, "18.4910856038332 GB/s")] | ||
| [InlineData(19854651984, 1, TimeUnit.Second, null, "18.49 GB/s")] |
Contributor
Author
There was a problem hiding this comment.
Weird. This line isn't present in main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue happening only when
ToString()is invoked on aByteSize. Since parameterlessToStringis optimized and doesn't invokeToString(string format)it uses{0} {1}to create an output string, but this format has no information on how a value should be displayed and prints a number with high precision.