Fix Safari mobile background scrolling#211
Open
timi2shoes wants to merge 2 commits intoHubSpot:masterfrom
Open
Fix Safari mobile background scrolling#211timi2shoes wants to merge 2 commits intoHubSpot:masterfrom
timi2shoes wants to merge 2 commits intoHubSpot:masterfrom
Conversation
Update fix to keep background from scrolling in Safari
Update vex.css
Contributor
|
Can you explain what this fix does? |
Author
|
Well at first it looked good, but it had the unintended consequence of scrolling to the top, not sure people will like that. The problem i was trying to fix is safari webview and the cursor not being inline with each other when scrolling and view behind the modal can be scrolled. |
Contributor
|
@timi2shoes, did the fix in #223 address your problem? We're releasing version 4.0.0 soon with the change, in the meantime you can checkout the code from this repo directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.