make vex-close a button to help with accessibility#134
Open
WesKetch wants to merge 1 commit intoHubSpot:masterfrom
Open
make vex-close a button to help with accessibility#134WesKetch wants to merge 1 commit intoHubSpot:masterfrom
WesKetch wants to merge 1 commit intoHubSpot:masterfrom
Conversation
Contributor
|
👍 |
|
You could achieve the same with something similar to the below code snippet. The point is to make the screenreader think it deals with a button. Tho, from a markup point of view I like it more to have more expressive markup so that you immediately know the meaning of a markup element if you see it for the first time. That is if you want to provide a button use Also use the aria-label role instead of title. See: http://wesbos.com/times-html-entity-close-button/ Any plans to merge this PR with #133 to get both into the master branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #133
Hello,
I have been working on making the vex modal more accessible. By using a button to close the modal instead of a div, someone can now focus on the button using the tab key, and close the button using the enter key. I have gone through all the themes to make sure the styles are consistent. CSS is not my strongest skill so I may be a little off on some of them.
Thanks!