Hand Evaluator Indexing Problems #1
Description
In running some simple tests with Quads, the evaluator appears to give the wrong index for two-pair hands and high card hands. The worst three of a kind hand, 2234, has rank 2467. The best two-pair hand, AAKKQ, has rank 2467 which should be 2468. The worst two-pair hand, 22334, has rank 3324, which should be 3325. The worst one-pair hand, 22345, has rank 6185. The best high card hand, AKQJ9, has rank 6185, but it should be 6186. The worst high card hand, 23457, has rank 7461, but it should be 7462.
Comparing to the Python implementation of lookup.py in worldveil/deuces, it looks like this may be two simple typos in Lookup.jl, failing to initialize the rank variable correctly. I think perhaps the fix is just adding +1 on two separate lines.
- On line 231, rank = MAX_THREE_OF_A_KIND + 1
- On line 103 , rank = MAX_PAIR + 1
I haven't gone through the code very carefully, and would appreciate if you can take a look to see if this is on the right track.