This repository was archived by the owner on Mar 29, 2022. It is now read-only.
Non scoring PRs for winning or completed users#382
Open
Non scoring PRs for winning or completed users#382
Conversation
fridaland
changed the title
added 6 commits
October 30, 2019 15:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of a completed/winning user, a bonus nonscoring PR can potentially be lost. This would happen when an originally valid PR is marked as invalid or lost and then this bonus nonscoring PR would be bumped to scoring PRs. However, the user will simply see his bonus PR disappear in UI.
This PR refactors
non_scoring_pull_requeststo take acompleted_or_winninguser's PRs and compare them against their receipt to calculate their bonus PRs.