[#689] Reset cut is not updating view

[emiliocortina]

#689

[EdwardMoyse]

So, the plan here is to avoid type inference and make it explicit in the caller? Is there an advantage to this i.e. was this the cause of the problem?

(Just for my understanding)

[EdwardMoyse]

ping @emiliocortina ?

[EdwardMoyse]

Hey Emilio - thank you so much for doing this! I confirm that the reset cut button now works as expected. However, I think the cuts no longer do anything (for some reason which is not obvious to me).

For example, go to https://hepsoftwarefoundation.org/phoenix/#/atlas and load the attached config file - the screen should go blank. But when I do this locally, the jets (the blue cones) are still visible.

I just did some debugging, and I still cannot see the problem. AFAICS the SceneManager::collectionFilter function is called correctly, and correctly sets all child objects to visible === false. Is it possible the SceneManager is being copied i.e. it is no longer a singleton and is modifying a Scene which is not the same as we see?

Less importantly, you can find out how to fix the CI failure
here

TL;DR: run yarn lint:fix

[EdwardMoyse]

Hmm. A bit more debugging, and I think the issue might be that cut dialog ownership is not correct - cuts work for the first Jet collection ("AntiKt4EMTopoJets_xAOD") but for the second ("AntiKt4LCTopoJets_xAOD") the collectionName in collectionFilter is still "AntiKt4EMTopoJets_xAOD", AND if both are visible, the cuts from the second apply to the first.

[EdwardMoyse]

Yeah, this is definitely it. In addObjectType for the first collection there is no configRangeSlider on the cuts. However, once we get to the second collection there is. So in this case, the new configRangeSlider is never created here:

 public getConfigRangeSlider(
    collectionFiltering: () => void,
  ): ConfigRangeSlider {
    if (this.configRangeSlider == undefined) {
      this.configRangeSlider = {
        type: 'rangeSlider',

[emiliocortina]

This is great! I took a look a couple of days ago and I found it very weird that it was working for the tracks, but not for the jets