Skip to content

Conversation

@Nemikolh
Copy link
Contributor

AaribaScript editor + Project setup

This PR implement partially RSP-1 (GreenPix/meta#1) within the editor to allow easy debug/implementation and more importantly propagate the changes up to the back-end that Vesperae will then consume at run-time.

Tasks:

  • Basic setup of the editor
  • Autocompletion
    • Autocomplete on globals
    • Autocomplete on locals
  • Syntax highlighting
    • Support for comments
    • Highlight all other tokens
  • PEGjs interpreter
    • Support for expression
    • Support for if
    • Support for sin, cos, rand, %, max and min.
    • Support for comments
    • Fix bugs with error reporting
    • Support for default operator: ?
  • Inject PEG failure as lint in the editor
  • Fold if
  • Fold comments.
  • Add behavior that automatically add a } after pressing enter for a if
  • Back-end script management
    • creation
    • listing
    • edition
    • socket.io for lock/free on resources (bonus: update read-only content)
  • Basic user authentication (to have a real end to end solution)
  • Front-end management
    • Open a script
    • Commit a revision
    • Create a script
    • Update read-only content modified by user x
    • Sync file list: length and lock state

@Nemikolh Nemikolh added this to the aaribascript milestone Sep 20, 2015
@Nemikolh Nemikolh self-assigned this Sep 20, 2015
@Nemikolh Nemikolh modified the milestones: aaribascript, dilia-r6 Sep 20, 2015
@ghost
Copy link

ghost commented Sep 21, 2015

I don't think setting the milestone before merging is a good idea. What if you do not have time to finish this PR before the next monthly recap? You always can set a new milestone of course, but from my point of view, milestone should be add after merging. It's more error-free.

@Nemikolh
Copy link
Contributor Author

I understand your point for future PR. Here we can leave the milestone as it is going to be merged soon (should be done by the end of the week).

Thanks for the feedback !

@ghost
Copy link

ghost commented Sep 21, 2015

That's great news! Before merging it, can you ping me? I would love to test your work, in order to help and (maybe, maybe not) find potential bugs.

@Nemikolh
Copy link
Contributor Author

Yes of course! 😃 I'll keep you up to date.

@Nemikolh Nemikolh added the rsp-1 label Sep 21, 2015
@Nemikolh
Copy link
Contributor Author

@Ikyushii I intend to merge this (now really long) PR after review before the next recap. If you would like to discuss what to say about it, ping me by email and we can discuss it.

@ghost
Copy link

ghost commented Oct 29, 2015

@Nemikolh : It’s a huge PR indeed. I will try to review this as soon as possible and yes, we’ll need to discuss a little :).

@Nemikolh
Copy link
Contributor Author

@Ikyushii Yeah it is. x) Hopefully, the actual logic is relatively thin. Most of the PR is really about the project set up. If I have time, I'll try to set up an heroku instance to play and discuss around it.

@Nemikolh
Copy link
Contributor Author

@Ikyushii Do you think you could a quick review of the PR? The PR is ready. I would like to merge it and move on something else.

Nemikolh added a commit that referenced this pull request Dec 9, 2015
AaribaScript editor support + Project setup
@Nemikolh Nemikolh merged commit 44bbed5 into master Dec 9, 2015
@Nemikolh Nemikolh deleted the rule-editor branch December 9, 2015 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants