-
Notifications
You must be signed in to change notification settings - Fork 2
AaribaScript editor support + Project setup #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I don't think setting the milestone before merging is a good idea. What if you do not have time to finish this PR before the next monthly recap? You always can set a new milestone of course, but from my point of view, milestone should be add after merging. It's more error-free. |
|
I understand your point for future PR. Here we can leave the milestone as it is going to be merged soon (should be done by the end of the week). Thanks for the feedback ! |
|
That's great news! Before merging it, can you ping me? I would love to test your work, in order to help and (maybe, maybe not) find potential bugs. |
|
Yes of course! 😃 I'll keep you up to date. |
|
@Ikyushii I intend to merge this (now really long) PR after review before the next recap. If you would like to discuss what to say about it, ping me by email and we can discuss it. |
|
@Nemikolh : It’s a huge PR indeed. I will try to review this as soon as possible and yes, we’ll need to discuss a little :). |
|
@Ikyushii Yeah it is. x) Hopefully, the actual logic is relatively thin. Most of the PR is really about the project set up. If I have time, I'll try to set up an heroku instance to play and discuss around it. |
…ow lookup the list of files.
|
@Ikyushii Do you think you could a quick review of the PR? The PR is ready. I would like to merge it and move on something else. |
AaribaScript editor support + Project setup
AaribaScript editor + Project setup
This PR implement partially RSP-1 (GreenPix/meta#1) within the editor to allow easy debug/implementation and more importantly propagate the changes up to the back-end that Vesperae will then consume at run-time.
Tasks:
Autocomplete on localsifsin,cos,rand,%,maxandmin.?ifFold comments.}after pressing enter for aif