Websocket: included modelName in getNext response, critical requirement for multimodel implementation through websocket#237
Merged
KristianKarl merged 1 commit intoGraphWalker:masterfrom May 26, 2020
Conversation
…nt for multimodel implementation through websocket
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
=========================================
Coverage 76.13% 76.13%
Complexity 1216 1216
=========================================
Files 129 129
Lines 4462 4463 +1
Branches 677 677
=========================================
+ Hits 3397 3398 +1
Misses 828 828
Partials 237 237 |
Contributor
|
Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added modelName in response object of Websocket getNext command
it is a critical requirement for multi-model implementation through WebSocket where we need model Name also to call the required function inside the Model's class