Migrate transformers to using lazy properties #1036
Merged
+305
−182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goooler
force-pushed
the
g/lazy-properties
branch
4 times, most recently
from
de2ef05 to
7e5148a
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 14 changed files in this pull request and generated no suggestions.
Files not reviewed (12)
- api/shadow.api: Language not supported
- lint-baseline.xml: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowPlugin.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/AbstractDependencyFilter.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/UnusedTracker.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/Utils.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/relocation/SimpleRelocator.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ApacheNoticeResourceTransformer.kt: Language not supported
- src/test/groovy/com/github/jengelman/gradle/plugins/shadow/ConfigureShadowRelocationSpec.groovy: Language not supported
Goooler
force-pushed
the
g/lazy-properties
branch
7 times, most recently
from
518ecce to
fa22933
Compare
1 task
Goooler
changed the base branch from
main
to
g/migrate-shadow-jar-to-lazy-properties
Goooler
force-pushed
the
g/lazy-properties
branch
from
b8f956c to
3a76edc
Compare
Goooler
changed the title
Base automatically changed from
g/migrate-shadow-jar-to-lazy-properties
to
main
November 26, 2024 09:37
Goooler
force-pushed
the
g/lazy-properties
branch
2 times, most recently
from
8d1347b to
1df7b3b
Compare
Goooler
force-pushed
the
g/lazy-properties
branch
from
1df7b3b to
8ec6041
Compare
Goooler
force-pushed
the
g/lazy-properties
branch
from
8ec6041 to
602349d
Compare
Goooler
force-pushed
the
g/lazy-properties
branch
from
a039e01 to
1c54a37
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 22 changed files in this pull request and generated no suggestions.
Files not reviewed (20)
- api/shadow.api: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/internal/Utils.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ApacheNoticeResourceTransformer.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/AppendingTransformer.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/DontIncludeResourceTransformer.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/IncludeResourceTransformer.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ManifestAppenderTransformer.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/ManifestResourceTransformer.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/PropertiesFileTransformer.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/Transformer.kt: Language not supported
- src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/transformers/XmlAppendingTransformer.kt: Language not supported
- src/test/groovy/com/github/jengelman/gradle/plugins/shadow/TransformerSpec.groovy: Language not supported
- src/test/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/ApacheNoticeResourceTransformerParameterTests.groovy: Language not supported
- src/test/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/ApacheNoticeResourceTransformerTest.groovy: Language not supported
- src/test/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/AppendingTransformerTest.groovy: Language not supported
- src/test/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/ManifestAppenderTransformerTest.groovy: Language not supported
- src/test/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/PropertiesFileTransformerSpec.groovy: Language not supported
- src/test/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/PropertiesFileTransformerTest.groovy: Language not supported
- src/test/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/TransformerSpecSupport.groovy: Language not supported
Goooler
force-pushed
the
g/lazy-properties
branch
from
57da1b1 to
32da3ee
Compare
Goooler
commented
Jan 27, 2025
Comment on lines
-164
to
+178
| if (keyTransformer === IDENTITY) { | ||
| if (keyTransformer == IDENTITY) { |
Member
Author
There was a problem hiding this comment.
The new keyTransformer needs to be get before check equals.
This was referenced Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.