Skip to content

Conversation

@amcolin
Copy link

@amcolin amcolin commented Feb 11, 2026

Description

Internal b/481401219

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples. labels Feb 11, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @amcolin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates a sample application to use a newer version of the Gemini model for batch prediction. This ensures the sample remains current with the latest available models, providing users with an up-to-date example of how to leverage advanced AI capabilities within their applications.

Highlights

  • Model Version Update: The CreateBatchPredictionGeminiJobSample has been updated to utilize the gemini-2.5-flash model, replacing the older gemini-2.0-flash-001 version.
Changelog
  • aiplatform/src/main/java/aiplatform/batchpredict/CreateBatchPredictionGeminiJobSample.java
    • Updated the model name from 'gemini-2.0-flash-001' to 'gemini-2.5-flash'.
Activity
  • No activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the model name used in the CreateBatchPredictionGeminiJobSample from gemini-2.0-flash-001 to gemini-2.5-flash. This change aligns with the pull request title and appears to be a direct update of the model version. The primary feedback concerns a maintainability improvement for the hardcoded model name.

String.format(
"projects/%s/locations/%s/publishers/google/models/%s",
project, location, "gemini-2.0-flash-001");
project, location, "gemini-2.5-flash");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The model name "gemini-2.5-flash" is hardcoded directly within the String.format call. For improved maintainability and to reduce the risk of typos, especially for critical API parameters like model names, it is generally a good practice to define such string literals as private static final String constants at the class level. This makes the value easier to locate and update if it changes in the future. Due to the constraint of only commenting on modified lines and providing compilable code suggestions, a direct code suggestion for adding a constant declaration is not provided here.

@amcolin amcolin marked this pull request as ready for review February 11, 2026 20:05
@amcolin amcolin requested review from a team and yoshi-approver as code owners February 11, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant