-
Notifications
You must be signed in to change notification settings - Fork 90
chore(deps): update symfony packages to v8 (major) #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore(deps): update symfony packages to v8 (major) #284
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine maintenance update, upgrading two key Symfony development dependencies, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, generated by Renovate, proposes updating symfony/css-selector and symfony/dom-crawler to version ^8.0.0. This update is critically flawed and should not be merged. The primary issue is that version 8.0.0 of these Symfony components does not exist, which will cause the build to fail when composer tries to resolve dependencies. Additionally, such a major version jump from v5 would require a significant PHP version upgrade. The project currently requires php: ^7.1.3, while recent Symfony versions like v6 and v7 require PHP 8.1+ and 8.2+ respectively. I recommend closing this pull request. To upgrade these dependencies correctly, the project's PHP version should be updated first, followed by an update of the Symfony components to a compatible and existing version.
| "symfony/dom-crawler": "^8.0.0", | ||
| "symfony/css-selector": "^8.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The target versions ^8.0.0 for symfony/dom-crawler and symfony/css-selector are invalid and will break the build.
- Non-existent versions: Version
8.0.0for these packages has not been released. Attempting to install these dependencies will result in acomposererror. - PHP version incompatibility: The project's
composer.jsonrequiresphp: ^7.1.3. Newer versions of Symfony components require a much more recent PHP version. For instance, Symfony 6 requires PHP >= 8.1, and Symfony 7 requires PHP >= 8.2.
This automated update should be rejected. A proper upgrade would first involve updating the PHP version for the project, then updating the Symfony components to a compatible and existing version (e.g., ^6.4 or ^7.0). I'm suggesting reverting this change.
| "symfony/dom-crawler": "^8.0.0", | |
| "symfony/css-selector": "^8.0.0" | |
| "symfony/dom-crawler": "^5.0.0", | |
| "symfony/css-selector": "^5.0.0" |
This PR contains the following updates:
^5.0.0→^8.0.0^5.0.0→^8.0.0Release Notes
symfony/css-selector (symfony/css-selector)
v8.0.0Compare Source
v7.4.0Compare Source
v7.3.6Compare Source
v7.3.0Compare Source
Changelog (symfony/css-selector@v7.3.0-RC1...v7.3.0)
v7.2.0Compare Source
Changelog (symfony/css-selector@v7.2.0-RC1...v7.2.0)
v7.1.6Compare Source
Changelog (symfony/css-selector@v7.1.5...v7.1.6)
v7.1.1Compare Source
Changelog (symfony/css-selector@v7.1.0...v7.1.1)
v7.1.0Compare Source
Changelog (symfony/css-selector@v7.1.0-RC1...v7.1.0)
v7.0.8Compare Source
Changelog (symfony/css-selector@v7.0.7...v7.0.8)
v7.0.7Compare Source
Changelog (symfony/css-selector@v7.0.6...v7.0.7)
v7.0.3Compare Source
Changelog (symfony/css-selector@v7.0.2...v7.0.3)
v7.0.0Compare Source
Changelog (symfony/css-selector@v7.0.0-RC2...v7.0.0)
v6.4.24Compare Source
Changelog (symfony/css-selector@v6.4.23...v6.4.24)
v6.4.13Compare Source
Changelog (symfony/css-selector@v6.4.12...v6.4.13)
v6.4.8Compare Source
Changelog (symfony/css-selector@v6.4.7...v6.4.8)
v6.4.7Compare Source
Changelog (symfony/css-selector@v6.4.6...v6.4.7)
v6.4.3Compare Source
Changelog (symfony/css-selector@v6.4.2...v6.4.3)
v6.4.0Compare Source
Changelog (symfony/css-selector@v6.4.0-RC2...v6.4.0)
v6.3.12Compare Source
Changelog (symfony/css-selector@v6.3.11...v6.3.12)
v6.3.2Compare Source
Changelog (symfony/css-selector@v6.3.1...v6.3.2)
v6.3.0Compare Source
Changelog (symfony/css-selector@v6.3.0-RC2...v6.3.0)
v6.2.13Compare Source
Changelog (symfony/css-selector@v6.2.12...v6.2.13)
v6.2.7Compare Source
Changelog (symfony/css-selector@v6.2.6...v6.2.7)
v6.2.5Compare Source
Changelog (symfony/css-selector@v6.2.4...v6.2.5)
v6.2.3Compare Source
Changelog (symfony/css-selector@v6.2.2...v6.2.3)
v6.2.0Compare Source
Changelog (symfony/css-selector@v6.2.0-RC2...v6.2.0)
v6.1.11Compare Source
v6.1.9Compare Source
Changelog (symfony/css-selector@v6.1.8...v6.1.9)
v6.1.3Compare Source
Changelog (symfony/css-selector@v6.1.2...v6.1.3)
v6.1.0Compare Source
Changelog (symfony/css-selector@v6.1.0-RC1...v6.1.0)
v6.0.19Compare Source
Changelog (symfony/css-selector@v6.0.18...v6.0.19)
v6.0.17Compare Source
Changelog (symfony/css-selector@v6.0.16...v6.0.17)
v6.0.11Compare Source
Changelog (symfony/css-selector@v6.0.10...v6.0.11)
v6.0.3Compare Source
Changelog (symfony/css-selector@v6.0.2...v6.0.3)
v6.0.2Compare Source
Changelog (symfony/css-selector@v6.0.1...v6.0.2)
v6.0.1Compare Source
Changelog (symfony/css-selector@v6.0.0...v6.0.1)
v6.0.0Compare Source
Changelog (symfony/css-selector@v6.0.0-RC1...v6.0.0)
symfony/dom-crawler (symfony/dom-crawler)
v8.0.1Compare Source
Changelog (symfony/dom-crawler@v8.0.0...v8.0.1)
v8.0.0Compare Source
v7.4.1Compare Source
Changelog (symfony/dom-crawler@v7.4.0...v7.4.1)
v7.4.0Compare Source
v7.3.3Compare Source
Changelog (symfony/dom-crawler@v7.3.2...v7.3.3)
v7.3.1Compare Source
Changelog (symfony/dom-crawler@v7.3.0...v7.3.1)
buttons by theirvalue(@MatTheCat)v7.3.0Compare Source
Changelog (symfony/dom-crawler@v7.3.0-RC1...v7.3.0)
v7.2.8Compare Source
Changelog (symfony/dom-crawler@v7.2.7...v7.2.8)
buttons by theirvalue(@MatTheCat)v7.2.4Compare Source
Changelog (symfony/dom-crawler@v7.2.3...v7.2.4)
v7.2.3Compare Source
Changelog (symfony/dom-crawler@v7.2.2...v7.2.3)
ChoiceFormField::isDisabledreturntruefor unchecked disabled checkboxes (@MatTheCat)v7.2.0Compare Source
Changelog (symfony/dom-crawler@v7.2.0-RC1...v7.2.0)
parse_url()bug (bis) (@nicolas-grekas)v7.1.11Compare Source
Changelog (symfony/dom-crawler@v7.1.10...v7.1.11)
ChoiceFormField::isDisabledreturntruefor unchecked disabled checkboxes (@MatTheCat)v7.1.9Compare Source
Changelog (symfony/dom-crawler@v7.1.8...v7.1.9)
parse_url()bug (bis) (@nicolas-grekas)v7.1.6Compare Source
Changelog (symfony/dom-crawler@v7.1.5...v7.1.6)
parse_url()checks (@nicolas-grekas)v7.1.5Compare Source
Changelog (symfony/dom-crawler@v7.1.4...v7.1.5)
parse_url()bug (@nicolas-grekas)v7.1.1Compare Source
Changelog (symfony/dom-crawler@v7.1.0...v7.1.1)
v7.1.0Compare Source
Changelog (symfony/dom-crawler@v7.1.0-RC1...v7.1.0)
v7.0.8Compare Source
Changelog (symfony/dom-crawler@v7.0.7...v7.0.8)
v7.0.7Compare Source
Changelog (symfony/dom-crawler@v7.0.6...v7.0.7)
v7.0.4Compare Source
Changelog (symfony/dom-crawler@v7.0.3...v7.0.4)
v7.0.3Compare Source
Changelog (symfony/dom-crawler@v7.0.2...v7.0.3)
v7.0.0Compare Source
Changelog (symfony/dom-crawler@v7.0.0-RC2...v7.0.0)
v6.4.25Compare Source
Changelog (symfony/dom-crawler@v6.4.24...v6.4.25)
v6.4.24Compare Source
Changelog (symfony/dom-crawler@v6.4.23...v6.4.24)
v6.4.23Compare Source
Changelog (symfony/dom-crawler@v6.4.22...v6.4.23)
buttons by theirvalue(@MatTheCat)v6.4.19Compare Source
Changelog (symfony/dom-crawler@v6.4.18...v6.4.19)
v6.4.18Compare Source
Changelog (symfony/dom-crawler@v6.4.17...v6.4.18)
ChoiceFormField::isDisabledreturntruefor unchecked disabled checkboxes (@MatTheCat)v6.4.16Compare Source
Changelog (symfony/dom-crawler@v6.4.15...v6.4.16)
parse_url()bug (bis) (@nicolas-grekas)v6.4.13Compare Source
Changelog (symfony/dom-crawler@v6.4.12...v6.4.13)
parse_url()checks (@nicolas-grekas)v6.4.12Compare Source
Changelog (symfony/dom-crawler@v6.4.11...v6.4.12)
parse_url()bug (@nicolas-grekas)v6.4.8Compare Source
Changelog (symfony/dom-crawler@v6.4.7...v6.4.8)
v6.4.7Compare Source
Changelog (symfony/dom-crawler@v6.4.6...v6.4.7)
v6.4.4Compare Source
Changelog (symfony/dom-crawler@v6.4.3...v6.4.4)
v6.4.3Compare Source
Changelog (symfony/dom-crawler@v6.4.2...v6.4.3)
v6.4.0Compare Source
Changelog (symfony/dom-crawler@v6.4.0-RC2...v6.4.0)
v6.3.12Compare Source
Changelog (symfony/dom-crawler@v6.3.11...v6.3.12)
v6.3.9Compare Source
Changelog (symfony/dom-crawler@v6.3.8...v6.3.9)
v6.3.4Compare Source
Changelog (symfony/dom-crawler@v6.3.3...v6.3.4)
v6.3.1Compare Source
Changelog (symfony/dom-crawler@v6.3.0...v6.3.1)
v6.3.0Compare Source
Changelog (symfony/dom-crawler@v6.3.0-RC2...v6.3.0)
v6.2.12Compare Source
Changelog (symfony/dom-crawler@v6.2.11...v6.2.12)
v6.2.9Compare Source
Changelog (symfony/dom-crawler@v6.2.8...v6.2.9)
v6.2.8Compare Source
Changelog (symfony/dom-crawler@v6.2.7...v6.2.8)
v6.2.7Compare Source
Changelog (symfony/dom-crawler@v6.2.6...v6.2.7)
v6.2.5Compare Source
Changelog (symfony/dom-crawler@v6.2.4...v6.2.5)
v6.2.3Compare Source
Changelog (symfony/dom-crawler@v6.2.2...v6.2.3)
v6.2.0Compare Source
Changelog (symfony/dom-crawler@v6.2.0-RC2...v6.2.0)
v6.1.11Compare Source
v6.1.9Compare Source
Changelog (symfony/dom-crawler@v6.1.8...v6.1.9)
v6.1.7Compare Source
Changelog (symfony/dom-crawler@v6.1.6...v6.1.7)
v6.1.4Compare Source
Changelog (symfony/dom-crawler@v6.1.3...v6.1.4)
v6.1.3Compare Source
Changelog (symfony/dom-crawler@v6.1.2...v6.1.3)
v6.1.0Compare Source
Changelog (symfony/dom-crawler@v6.1.0-RC1...v6.1.0)
v6.0.19Compare Source
Changelog (symfony/dom-crawler@v6.0.18...v6.0.19)
v6.0.17Compare Source
Changelog (symfony/dom-crawler@v6.0.16...v6.0.17)
v6.0.15Compare Source
Changelog (symfony/dom-crawler@v6.0.14...v6.0.15)
v6.0.12Compare Source
Changelog (symfony/dom-crawler@v6.0.11...v6.0.12)
v6.0.11Compare Source
Changelog (symfony/dom-crawler@v6.0.10...v6.0.11)
v6.0.9Compare Source
Changelog (symfony/dom-crawler@v6.0.8...v6.0.9)
v6.0.6Compare Source
Changelog (symfony/dom-crawler@v6.0.5...v6.0.6)
v6.0.5Compare Source
Changelog (symfony/dom-crawler@v6.0.4...v6.0.5)
v6.0.3Compare Source
Changelog (symfony/dom-crawler@v6.0.2...v6.0.3)
v6.0.2Compare Source
Changelog (symfony/dom-crawler@v6.0.1...v6.0.2)
v6.0.1Compare Source
Changelog (symfony/dom-crawler@v6.0.0...v6.0.1)
v6.0.0Compare Source
Changelog (symfony/dom-crawler@v6.0.0-RC1...v6.0.0)
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.