Extract (some) core logic #35
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to 'StringSymbolAttribute'
…nViewProperties' in namespace 'Views'
…ic into 'STROOP.Variables'
…tion for 'IVariable'
…pecialUtilities' to 'VariableSpecialDictionary'
Aurumaker72
requested changes
Jan 9, 2026
Collaborator
Aurumaker72
left a comment
Aurumaker72
left a comment
There was a problem hiding this comment.
There's an exception when opening the "Custom" tab.
System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values.
at STROOP.Utilities.ControlUtilities.AddCheckableDropDownItems[T](ToolStripMenuItem topLevelItem, List`1 itemNames, List`1 itemValues, Action`1 setterAction, T startingValue) in E:\repos\STROOP\STROOP\Utilities\ControlUtilities.cs:line 468
at STROOP.Tabs.CustomTab.InitializeTab() in E:\repos\STROOP\STROOP\Tabs\CustomTab.cs:line 43
at STROOP.Tabs.STROOPTab.UpdateOrInitialize(Boolean active) in E:\repos\STROOP\STROOP\Tabs\STROOPTab.cs:line 80
at STROOP.Tabs.STROOPTab.UpdateTab(TabPage page, Boolean active) in E:\repos\STROOP\STROOP\Tabs\STROOPTab.cs:line 18
at STROOP.StroopMainForm.OnUpdate() in E:\repos\STROOP\STROOP\Forms\StroopMainForm.cs:line 419
at STROOP.Core.CoreLoop.Run(CancellationToken cancellationToken, Action handleEvents, Func`1 getTargetedFps) in E:\repos\STROOP\STROOP.Core\CoreLoop.cs:line 24
at STROOP.StroopMainForm.OnShown(EventArgs e) in E:\repos\STROOP\STROOP\Forms\StroopMainForm.cs:line 209
at System.Windows.Forms.Control.InvokeMarshaledCallbackHelper(Object obj)
at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state)
Collaborator
|
I did some basic testing and everything else seems to be in order :D |
Aurumaker72
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves significant parts of STROOP's logic into dedicated C# projects while attempting to retain the functionality everywhere.
There may be breaking changes, and I reckon that the chances for odd bugs being introduced with this is fairly high - however, whatever may be broken or unintentionally changed should probably be reviewed with those motivations in mind that were laid out in #27 anyways.
Note that #27 will not be closed by this Pull Request entirely. There is still much work to be done.