feat: Enable realtime mode (SSE) #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khvn26
approved these changes
Dec 5, 2024
Member
khvn26
left a comment
khvn26
left a comment
There was a problem hiding this comment.
Looks good overall, aside from one question.
Comment on lines
+52
to
+56
| rescue Faraday::ConnectionFailed, Faraday::TimeoutError => e | ||
| @config.logger.warn "Connection failed: #{e.message}. Retrying in #{retry_interval} seconds..." | ||
| rescue StandardError => e | ||
| @config.logger.error "Error: #{e.message}. Retrying in #{retry_interval} seconds..." | ||
| end |
Member
There was a problem hiding this comment.
I can't quite understand the reasoning behind different logging levels for different errors here.
Contributor
Author
There was a problem hiding this comment.
The reason why we warn for a connection failed error is that it is expected behaviour. The SSE connection is, by design, going to fail after a poll of 30 seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This enables realtime mode for the Ruby client. Once the realtime endpoint provides a newly updated timestamp, the call to update the environment is triggered.
Testing
I manually tested against production data and verified that the realtime endpoint returns expected data. I also wrote five new tests that cover what was implemented.