fix: allow false as a flag value #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates Flag#from_api to support `false` as a valid value. Previously, `false` values for `:feature_state_value` would would fall through the `||` branch and end up using the value from `:value`, which in most (all?) cases seems to be `nil`. The previous behavior made it impossible to distinguish between the following two cases: - an enabled flag that has never had its value set (and should therefore be treated as `true`) - an enabled flag that is explicitly set to `false` (and should therefore be treated as `false`) With the change in this commit, the first case will be `nil`, and the second case would be `false`. The `:value` key will now only be consulted when there is no `:feature_state_value` key present in the JSON flag data.
Contributor
Author
|
I looked into writing tests for this, but I didn't see an easy way to write one without impacting other tests by adding a new fixture 😬 Happy to add a new fixture or an explicit test, though! |
zachaysan
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates
Flagsmith::Flags::Flag#from_apito supportfalseas a valid value.Previously,
falsevalues for:feature_state_valuewould would fall through the||branch and end up using the value from:value, which in most (all?) cases seems to benil.The previous behavior made it impossible to distinguish between the following two cases:
an enabled flag that has never had its value set (and should therefore be treated as
true)an enabled flag that is explicitly set to
false(and should therefore be treated asfalse)With the change in this commit, the first case will be
nil, and the second case would befalse. The:valuekey will now only be consulted when there is no:feature_state_valuekey present in the JSON flag data.