feat: Support transient identities and traits #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optional `transient` argument to `get_identity_flags` - Add support for trait configuration values with optional `transient` key - Remove unneeded default argument values from private methods - Remove unneeded comments from the spec
zachaysan
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63.
transientargument toget_identity_flagstransientkeyNotes:
rubocop:disable Style/OptionalBooleanParameterexclusion for the new argument toget_identity_flags. This is to avoid conflict in case a user intends to send a trait calledtransient.set_trait/get_traitsinterfaces that have not been implemented. I don't like having commented out code in general, and those methods are not expected to be there in a server-side SDK anyway.traits = {}from internal methods as they are not needed — the empty hash is always provided by the topget_identity_flagsinterface — but also because Rubocop complained about having non-optionaltransientargument aftertraits, and I did not want to change the argument order anywhere, or litter the default value fortransientthroughout the stack.