Return early if socket is not connected through proxy #2416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldoglas
approved these changes
Dec 17, 2025
tylerkaraszewski
requested changes
Dec 17, 2025
| if (state.load() == Socket::State::CONNECTING) { | ||
| return true; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I don't understand why this would make a difference given that the base class works without this.
Also, so far as I can tell, the only places we can call this are in STCPManager::postPoll gated on socket state being Socket::CONNECTED (here) or Socket::SHUTTINGDOWN (here) and I don't think the intended case is to skip when SHUTTINGDOWN.
Can you tell me where this gets called where this would be relevant, and maybe give an example case of what this fixes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
If a socket is not connected to the proxy, return early which will cause the poll loop to wait for a connection
Fixed Issues
relates to https://github.com/Expensify/Expensify/issues/578735
Tests
Internal Testing Reminder: when changing bedrock, please compile auth against your new changes