Fix mistake in PR #4226 #4228
Merged
Fix mistake in PR #4226 #4228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added that because I thought it was needed. Spoiler alert, it wasn't.
Having it set to less that or equal to breaks what it was meant to do Instead of hiding players with a balance of 0 it only shows players with a balance of 0
JRoy
approved these changes
Jun 12, 2021
ressidell
pushed a commit
to ressidell/Essentials
that referenced
this pull request
Apr 27, 2025
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes a mistake in PR #4226.
Details
Proposed fix:
Actually use the correct '>' instead of '<='
Having <= will hide any players with a balance greater then 0, this is the opposite of what was intended with the patch
Environments tested:
OS: Linux 4.15.0-88-generic
Java version: Java 11 (OpenJDK 64-Bit Server VM 11.0.11+9-Ubuntu-0ubuntu2.20.04)
Demonstration:
N\A