Skip to content

Conversation

@devxoul
Copy link
Contributor

@devxoul devxoul commented Apr 3, 2021

Fix #4099

I'm not sure 2.x is the correct target branch for this PR.

@devxoul devxoul changed the title Return false when user doesn't have permission to spawn item Check permissions when user attempt to spawn items Apr 3, 2021
@devxoul
Copy link
Contributor Author

devxoul commented Apr 3, 2021

I'm not sure why build fails :(

@Octol1ttle
Copy link
Contributor

I'm not sure why build fails :(

It fails because you forgot the semicolon at the end. In the future, read the check log to see why the build fails
Also, did you test this PR to see if it actually solves the issue?

@devxoul devxoul force-pushed the canspawnitem-false branch from f9c1754 to 6f76faa Compare April 3, 2021 14:49
@devxoul
Copy link
Contributor Author

devxoul commented Apr 3, 2021

@l1ttleO Thanks! I didn't see any semicolon related error message from the log. I just fixed.

I haven't tested. I just saw the old code and found something was missing in the newer code.

@devxoul
Copy link
Contributor Author

devxoul commented Apr 3, 2021

@l1ttleO, I just tested and it works 😉

Command: /item stone 1

  • essentials.item
    Screen Shot 2021-04-04 at 12 21 28 AM
  • essentials.item and essentials.itemspawn.item-stone
    Screen Shot 2021-04-04 at 12 22 01 AM

@JRoy JRoy changed the title Check permissions when user attempt to spawn items Fix regression in permission based item spawning Apr 3, 2021
@JRoy JRoy merged commit 0668e4c into EssentialsX:2.x Apr 3, 2021
@JRoy
Copy link
Member

JRoy commented Apr 3, 2021

Thanks for this fix!

@devxoul devxoul deleted the canspawnitem-false branch April 3, 2021 15:38
ressidell pushed a commit to ressidell/Essentials that referenced this pull request Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Permission based item spawn doesn't actually check permissions

3 participants