Skip to content

Conversation

@JRoy
Copy link
Member

@JRoy JRoy commented Feb 10, 2021

This PR:

  • Implements a new provider for VaultAPI's Economy
    • The legacy provider built into Vault uses player names, and has not changed since Vault was invented in 1864.
    • This properly supports UUIDs and works more predictably with EssentialsX.
  • Replaces the Register method economy abstraction layer abstraction layer with a new EconomyLayer economy abstraction layer abstraction layer.
    • This opens the pathway for future economy abstraction layers to be supported.
    • This change also removes dubiously-licensed code from the project.

/MD edit


Fixes #4110
Closes #3344
Closes #2401

when merged, send messages to the following issues explaining the problem and that this "fixes" it;
#3974
#4036
#3978
#4008
#3991
#4024
#2490
#4079
#4120

@JRoy JRoy added the type: enhancement Features and feature requests. label Feb 10, 2021
@JRoy JRoy added this to the 2.19.0 milestone Feb 10, 2021
@mdcfe mdcfe force-pushed the feature/the-vault-chronicles branch from cd56fa2 to 7943df6 Compare February 10, 2021 15:05
@JRoy JRoy requested a review from mdcfe February 25, 2021 05:21
@mdcfe mdcfe self-assigned this Mar 6, 2021
mdcfe
mdcfe previously approved these changes May 10, 2021
@mdcfe mdcfe self-requested a review May 10, 2021 16:01
@mdcfe mdcfe dismissed their stale review May 10, 2021 16:02

Pending a few final confirmations

@mdcfe mdcfe changed the title Migrate to our new Vault provider Migrate to new Vault provider and economy integration May 10, 2021
@mdcfe mdcfe enabled auto-merge (squash) May 10, 2021 16:10
Copy link
Member

@mdcfe mdcfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the longest amount of time I have ever spent on admin while merging a PR

@mdcfe mdcfe disabled auto-merge May 10, 2021 19:34
@mdcfe mdcfe enabled auto-merge (squash) May 10, 2021 19:35
@mdcfe mdcfe merged commit 071f995 into 2.x May 10, 2021
@JRoy
Copy link
Member Author

JRoy commented May 10, 2021

Hello, this issue has been mitigated in recent EssentialsX dev builds!

If you currently have damaged data, you can read more about the steps you can take to fix this and prevent further issues of this sort here.

Download the latest dev build here.

@JRoy JRoy deleted the feature/the-vault-chronicles branch May 10, 2021 20:48
ressidell pushed a commit to ressidell/Essentials that referenced this pull request Apr 27, 2025
This commit:
- Implements a new provider for VaultAPI's `Economy`
  - The legacy provider built into Vault uses player names, and has not changed since Vault was invented in 1864.
  - This properly supports UUIDs and works more predictably with EssentialsX.
- Replaces the Register method economy abstraction layer abstraction layer with a new `EconomyLayer` economy abstraction layer abstraction layer.
  - This opens the pathway for future economy abstraction layers to be supported.
  - This change also removes dubiously-licensed code from the project.

For users encountering userdata issues on this build, see this FAQ entry:
EssentialsX#3956 (comment)

Fixes EssentialsX#4110.
Closes EssentialsX#3344.
Closes EssentialsX#2401.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Features and feature requests.

Projects

None yet

3 participants