-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Migrate to new Vault provider and economy integration #3975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd56fa2 to
7943df6
Compare
mdcfe
previously approved these changes
May 10, 2021
Essentials/src/main/java/com/earth2me/essentials/economy/EconomyLayers.java
Show resolved
Hide resolved
mdcfe
approved these changes
May 10, 2021
Member
mdcfe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the longest amount of time I have ever spent on admin while merging a PR
Member
Author
ressidell
pushed a commit
to ressidell/Essentials
that referenced
this pull request
Apr 27, 2025
This commit: - Implements a new provider for VaultAPI's `Economy` - The legacy provider built into Vault uses player names, and has not changed since Vault was invented in 1864. - This properly supports UUIDs and works more predictably with EssentialsX. - Replaces the Register method economy abstraction layer abstraction layer with a new `EconomyLayer` economy abstraction layer abstraction layer. - This opens the pathway for future economy abstraction layers to be supported. - This change also removes dubiously-licensed code from the project. For users encountering userdata issues on this build, see this FAQ entry: EssentialsX#3956 (comment) Fixes EssentialsX#4110. Closes EssentialsX#3344. Closes EssentialsX#2401.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
EconomyEconomyLayereconomy abstraction layer abstraction layer./MD edit
Fixes #4110
Closes #3344
Closes #2401
when merged, send messages to the following issues explaining the problem and that this "fixes" it;
#3974
#4036
#3978
#4008
#3991
#4024
#2490
#4079
#4120