Fix duplicate nickname check with custom display names #3922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts the check to see if a nickname is in use to split on the nickname prefix, rather than replace. This ensures the check is performed correctly when other plugins adds prefixes or things to the display name (eg: PEX)
Member
|
Better solution would be to directly get the nickname through User methods and compare that way |
Contributor
Author
|
True. The main reason I did it this way was to keep the changes to a minimum, but that would also work |
JRoy
previously approved these changes
Jan 28, 2021
JRoy
changed the title
JRoy
approved these changes
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This fixes a quirk in which if the display name is changed by another plugin (eg: prefixes from PEX), it is possible for two online users to change their nicknames to be the same. As far as I can tell, no such previous issue exists.
Details
Proposed fix:
Check for nickname similarity switched to split on nickname prefix, rather than replace it. This avoids capturing anything in the display name before the nickname prefix, which correctly shows a warning if a duplicate exists.
Environments tested: