Prevent sending usage info when executing alternative commands #3904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JRoy
approved these changes
Jan 9, 2021
Member
|
pogchamp! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #3902, where Essentials will send its own command usage information during the execution of an alternative command if the alternative command returns
false.This PR also fixes a tiny bug where running
/ess commandswould output the name of an overriding plugin twice if the overriding plugin directly registered their command (not an alias).Before and after:
Details
Proposed fix:
Always return
truewhen executing alternative commands to prevent Essentials from sending its own usage, regardless of the outcome of the alternative command.Environments tested: