-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Allow enchants on fireworks/charges/potions/banners #3882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I have to stop coding at night
Essentials/src/main/java/com/earth2me/essentials/MetaItemStack.java
Outdated
Show resolved
Hide resolved
|
Needs conflict resolving from latest commits (maybe my previous review comment should also make sense given my recent PR to fix some firework meta stuff) |
JRoy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this would allow fireworks/potions/etc to parse enchantments, it would not, for example, parse a firework with firework meta and enchantment meta. If that can be added (maybe by splitting meta into a hashmap of tokens?)
Wait, but isn't |
That should be fixed ideally then. |
Co-authored-by: Josh Roy <10731363+JRoy@users.noreply.github.com>

This PR fixes #3879
Also added
pas a short name forpowerfor fireworks meta.