Skip to content

Conversation

@ploppyperson
Copy link
Contributor

This PR fixes #3872

Proposed fix: Add check if exploding block material is tnt.

Environments tested: git-Paper-325 (MC: 1.16.4)

@pop4959
Copy link
Member

pop4959 commented Dec 26, 2020

What happens with beds if tnt explosion damage is disabled? You should make sure that servers are still able to disable beds.

@ploppyperson
Copy link
Contributor Author

What happens with beds if tnt explosion damage is disabled? You should make sure that servers are still able to disable beds.

If protect.prevent.tnt-playerdamage is enabled, then TNT doesn't do damage but beds still do.

@pop4959
Copy link
Member

pop4959 commented Dec 26, 2020

If protect.prevent.tnt-playerdamage is enabled, then TNT doesn't do damage but beds still do.

Sorry if not clear, what I'm really asking is with this PR are servers able to both:

  • enable tnt damage but disable bed damage
  • enable bed damage but disable tnt damage

Just want to make sure because this was catching both before, but it should be possible to control them individually. In addition, you should check that any other exploding blocks are handled correctly too.

@ploppyperson
Copy link
Contributor Author

If protect.prevent.tnt-playerdamage is enabled, then TNT doesn't do damage but beds still do.

Sorry if not clear, what I'm really asking is with this PR are servers able to both:

* enable tnt damage but disable bed damage

* enable bed damage but disable tnt damage

Just want to make sure because this was catching both before, but it should be possible to control them individually. In addition, you should check that any other exploding blocks are handled correctly too.

The PR just means that the config option for tnt damage only disables tnt damage and not bed damage. I can add config options for bed damage if required?

@pop4959
Copy link
Member

pop4959 commented Dec 26, 2020

Would only be required if the change breaks behavior that previously was expected.

@triagonal triagonal added bug: confirmed Confirmed bugs in EssentialsX. type: bugfix PRs that fix bugs in EssentialsX. and removed bug: confirmed Confirmed bugs in EssentialsX. labels Jan 9, 2021
@ploppyperson ploppyperson requested a review from JRoy April 7, 2021 16:59
@JRoy JRoy added this to the 2.19.0 milestone Jun 11, 2021
@JRoy JRoy changed the title Fix damage from exploding beds being cancelled. Fix damage from exploding beds being cancelled Jun 11, 2021
@JRoy JRoy enabled auto-merge (squash) June 11, 2021 15:04
@JRoy JRoy merged commit 8142da6 into EssentialsX:2.x Jun 11, 2021
ressidell pushed a commit to ressidell/Essentials that referenced this pull request Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bugfix PRs that fix bugs in EssentialsX.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Beds don't do player damage when tnt-explosion is disabled

4 participants