-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Improve VersionUtil version checks #3812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Essentials/src/main/java/com/earth2me/essentials/Essentials.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/commands/Commandessentials.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/utils/VersionUtil.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/Essentials.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/utils/VersionUtil.java
Outdated
Show resolved
Hide resolved
Co-authored-by: l1ttleO <61277953+l1ttleO@users.noreply.github.com>
|
Can you also add Fabric if that's possible? |
|
ehhh essentials cant even start on a Fabric server....? |
yeah sure
it can with translation layers like Fukkit but still shouldn't be |
Ah I see, in that case if you want, you can also add Nukkit (bedrock server type) to the list. There is a plugin called Pokkit that supposing allows Bukkit based plugin to work, but as usual, these type of hybrid hacks shouldn't be used. |
Essentials/src/main/java/com/earth2me/essentials/utils/VersionUtil.java
Outdated
Show resolved
Hide resolved
…Util.java Co-authored-by: Dylan Xaldin <Puremin0rez515@gmail.com>
|
The one thing I'm a bit concerned about with this PR is that the phrasing could unintentionally alienate users. I think it might be better to leave it at "Unsupported" for all to be less biased. |
I would agree if these were opinions but they have literally corrupted userdata in the past and the point of these messages are to warn users who don't know any better than to just make a vague unsupported message. |
Essentials/src/main/java/com/earth2me/essentials/utils/VersionUtil.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/utils/VersionUtil.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/utils/VersionUtil.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/com/earth2me/essentials/utils/VersionUtil.java
Outdated
Show resolved
Hide resolved
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
Co-authored-by: Dylan Xaldin <Puremin0rez515@gmail.com> Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
Summary;
UNSTABLE