Skip to content

Conversation

@JRoy
Copy link
Member

@JRoy JRoy commented Dec 6, 2020

Summary;

  • Adds warning/recommendations for potentially dangerous server softwares
  • Now classifies servers without nms packages/classes as UNSTABLE

@JRoy JRoy added the type: enhancement Features and feature requests. label Dec 6, 2020
@JRoy JRoy added this to the 2.19.0 milestone Dec 6, 2020
@JRoy JRoy requested a review from mdcfe December 6, 2020 05:45
@JRoy JRoy requested a review from mdcfe December 6, 2020 15:20
JRoy and others added 2 commits December 6, 2020 10:40
Co-authored-by: l1ttleO <61277953+l1ttleO@users.noreply.github.com>
@Octol1ttle
Copy link
Contributor

Can you also add Fabric if that's possible?

@benwoo1110
Copy link

ehhh essentials cant even start on a Fabric server....?

@JRoy
Copy link
Member Author

JRoy commented Dec 10, 2020

Can you also add Fabric if that's possible?

yeah sure

ehhh essentials cant even start on a Fabric server....?

it can with translation layers like Fukkit but still shouldn't be

@benwoo1110
Copy link

it can with translation layers like Fukkit but still shouldn't be

Ah I see, in that case if you want, you can also add Nukkit (bedrock server type) to the list. There is a plugin called Pokkit that supposing allows Bukkit based plugin to work, but as usual, these type of hybrid hacks shouldn't be used.

darbyjack
darbyjack previously approved these changes Dec 14, 2020
…Util.java

Co-authored-by: Dylan Xaldin <Puremin0rez515@gmail.com>
@pop4959
Copy link
Member

pop4959 commented Dec 14, 2020

The one thing I'm a bit concerned about with this PR is that the phrasing could unintentionally alienate users. I think it might be better to leave it at "Unsupported" for all to be less biased.

@JRoy
Copy link
Member Author

JRoy commented Dec 14, 2020

The one thing I'm a bit concerned about with this PR is that the phrasing could unintentionally alienate users. I think it might be better to leave it at "Unsupported" for all to be less biased.

I would agree if these were opinions but they have literally corrupted userdata in the past and the point of these messages are to warn users who don't know any better than to just make a vague unsupported message.

@JRoy JRoy requested a review from mdcfe January 8, 2021 20:42
mdcfe
mdcfe previously approved these changes Jan 19, 2021
@mdcfe mdcfe enabled auto-merge (squash) January 19, 2021 09:59
@JRoy JRoy disabled auto-merge January 19, 2021 12:39
@JRoy JRoy merged commit 224634d into EssentialsX:2.x Jan 19, 2021
@JRoy JRoy deleted the feature/segregate-servers branch January 19, 2021 12:40
ressidell pushed a commit to ressidell/Essentials that referenced this pull request Apr 27, 2025
Co-authored-by: Dylan Xaldin <Puremin0rez515@gmail.com>
Co-authored-by: MD <1917406+mdcfe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement Features and feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants