Fix zh-CN GeoIP locale issue #3052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Einsfier
approved these changes
Mar 26, 2020
Einsfier
left a comment
Einsfier
left a comment
There was a problem hiding this comment.
Minor change for certain case.
Also with good backward-compatibility. No side effect should be introduced.
I am still suffering this issue, and I hope this should be merged ASAP.
Ichbinjoe
approved these changes
Mar 31, 2020
ressidell
pushed a commit
to ressidell/Essentials
that referenced
this pull request
Apr 27, 2025
Fix zh-CN GeoIP locale issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3036.
This is one proposed fix, which is to simply check for the zh locale from Essentials when building the database reader. There is no other locale in Essentials that has a mismatch with what MaxMind expects, except for this one, so it should work fine.
The other possible fix would be to rename the messages_zh.properties file to messages_zh_CN.properties, but this would break existing config for those users.