This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Fix OpAtomicFMaxEXT being used inside atomic_f_add
#995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
suggested changes
Mar 21, 2023
Contributor
eddyb
left a comment
eddyb
left a comment
There was a problem hiding this comment.
Sorry for forgetting about this! Can you add a CHANGELOG entry?
(please ping me for reviews)
Contributor
Author
|
@eddyb I added the changelog entry, now this should be ready :) |
eddyb
approved these changes
Mar 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #994