This repository was archived by the owner on Oct 31, 2025. It is now read-only.
warn when inline(never) is not respected #875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
suggested changes
May 21, 2022
Contributor
eddyb
left a comment
eddyb
left a comment
There was a problem hiding this comment.
Looks great, only had nits about Rust formatting and the warning phrasing (most importantly I think we should say #[inline(never)] since that's what would be in the source code).
eddyb
added
the
s: waiting on author
Co-authored-by: Eduard-Mihai Burtescu <edy.burt@gmail.com>
eddyb
reviewed
May 22, 2022
Comment on lines
1
to
6
| warning: function `nested_ref::deep_load` has `dont_inline` attribute, but need to be inlined because it has illegal argument or return types | ||
|
|
||
| warning: function `nested_ref::deep_transpose` has `dont_inline` attribute, but need to be inlined because it has illegal argument or return types | ||
|
|
||
| warning: 2 warnings emitted | ||
|
|
Contributor
There was a problem hiding this comment.
You'll need to git pull the new commit locally then run cargo compiletest --bless again to update this .stderr file.
eddyb
approved these changes
May 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.