This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Add new handling for SPIR-V targets #559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khyperia
approved these changes
Mar 30, 2021
Contributor
khyperia
left a comment
khyperia
left a comment
There was a problem hiding this comment.
Approved pending comment
khyperia
reviewed
Mar 30, 2021
Contributor
|
Also, we should think about deriving |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
XAMPPRocky
force-pushed
the
spirv-builder-target
branch
from
7cfedea to
7f2825c
Compare
VZout
reviewed
Apr 1, 2021
XAMPPRocky
force-pushed
the
spirv-builder-target
branch
2 times, most recently
from
821d779 to
3cdd8c6
Compare
XAMPPRocky
commented
Apr 9, 2021
XAMPPRocky
force-pushed
the
spirv-builder-target
branch
from
aadbcda to
9b0c601
Compare
XAMPPRocky
commented
Apr 9, 2021
XAMPPRocky
force-pushed
the
spirv-builder-target
branch
from
078ef73 to
3b16f69
Compare
XAMPPRocky
changed the title
XAMPPRocky
force-pushed
the
spirv-builder-target
branch
from
3b16f69 to
45e9561
Compare
khyperia
approved these changes
Apr 9, 2021
XAMPPRocky
force-pushed
the
spirv-builder-target
branch
from
c8feb80 to
f7567f0
Compare
Previously these were compiled for vulkan environments, now they're compiled to spv1.3 by default.
XAMPPRocky
added a commit
that referenced
this pull request
May 3, 2021
* Add new handling for SPIR-V targets * Ensure target is always three components
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a target argument that you can set a different target environment from
spirv-unknown-unknownwith spirv-builder.