Skip to content

Conversation

@MlgmXyysd
Copy link
Member

@MlgmXyysd MlgmXyysd commented Jan 4, 2020

Magisk v20.2 added a new API to add support for custom sepolicy rules to be applied in the pre-init phase [1,2].

This pull-request

  1. Updates the Magisk installer script to the latest version [1]
  2. Adds support for custom sepolicy rules [2]
  3. Converts the install method to the new variant using customize.sh [3]
  4. Fix OPPO Android P bootloop [5]
  5. Fix SandHook npe [6]
  6. Add stub app from https://github.com/ElderDrivers/EdXposedManager [7]

These rules are merged by Magisk and only applied once during the pre-init phase.

This should make the custom Magisk build obsolete (when using Magisk v20.2+).

[1] topjohnwu/Magisk@12fda29
[2] https://topjohnwu.github.io/Magisk/guides.html#sepolicyrule
[3] https://topjohnwu.github.io/Magisk/guides.html#magisk-module-installer
[4] #428
[5] wuxianlin@e009fa8
[6] asLody/SandHook#45
[7] ElderDrivers/EdXposedManager@56547eb

Thanks

m0vie and others added 5 commits January 4, 2020 11:09
- Convert install.sh to new customize.sh
- Set SKIPUNZIP=1 and handle the extraction ourselves
No need for custom Magisk builds anymore.
- Add custom sepolicy rule
- Add Riru version to log
- No hardcoded EdXposed version
- Magisk v20.2+ required
- No beta
@MlgmXyysd MlgmXyysd requested a review from solohsu January 4, 2020 06:24
@WiredLife
Copy link

Is there a compiled version to install via magisk?
Thanks!

@MlgmXyysd
Copy link
Member Author

@MlgmXyysd MlgmXyysd changed the title Support Magisk v20.2 SEPolicy API Support Magisk v20.2 SEPolicy API and fix OPPO Android P bootloop Jan 8, 2020
@MlgmXyysd MlgmXyysd changed the title Support Magisk v20.2 SEPolicy API and fix OPPO Android P bootloop Support Magisk v20.2 SEPolicy API and fix bootloop Jan 9, 2020
@Mikanoshi
Copy link

Mikanoshi commented Jan 15, 2020

When was EdXposed Installer support dropped?
I also have the same error with 0.4.6.1_4497: #443
Framework works though.

@MlgmXyysd
Copy link
Member Author

When was EdXposed Installer support dropped?
I also have the same error with 0.4.6.1_4497: #443
Framework works though.

Installer support dropped at 461bf58

re-install edxposed manager

@HpNoTiQ56
Copy link

What's included in Stub app and how to use it. I've compiled your last commit of Manager and I've got two APK : stub and release. Is it useful to pass S/N?

@MlgmXyysd
Copy link
Member Author

@HpNoTiQ56 no, just a stub, for give a link to download EdXposed Manager, and prevent to use unofficial closed-source EdXposed Manager

@Mikanoshi
Copy link

Mikanoshi commented Jan 31, 2020

Not if you have signature check disabled :) Anyway, do you really need an android support lib that makes apk almost 1MB just to show a dialog and open a link? Could be 50KB.

@nift4
Copy link

nift4 commented Feb 8, 2020

Why is this not merged? I use the canary builds with this PR on my daily driver Android Q.

@MlgmXyysd
Copy link
Member Author

Not if you have signature check disabled :) Anyway, do you really need an android support lib that makes apk almost 1MB just to show a dialog and open a link? Could be 50KB.

If I don't use appcompat, you'll only see Android 4. X style dialogs

@MlgmXyysd
Copy link
Member Author

Why is this not merged? I use the canary builds with this PR on my daily driver Android Q.

not completed

@nift4
Copy link

nift4 commented Feb 8, 2020

Oops

@MlgmXyysd
Copy link
Member Author

MlgmXyysd commented Feb 19, 2020

TODO:
[x] Completed persist detection
[x] Stub app
[ ] Module activation scope [1]

[1] Talk about Xposed new concept (Chinese)

Change-Id: I8d31014abff1ed15919ab10604a90be52d96c3a6
@MlgmXyysd
Copy link
Member Author

Not if you have signature check disabled :) Anyway, do you really need an android support lib that makes apk almost 1MB just to show a dialog and open a link? Could be 50KB.

Now removed appcompat

@MlgmXyysd
Copy link
Member Author

*If no more issues about persist partition detection (or sepolicy.rule) are submitted, this PR will be merged on March 1, 2020.

@MlgmXyysd MlgmXyysd self-assigned this Feb 29, 2020
@MlgmXyysd MlgmXyysd added the enhancement New feature or request label Feb 29, 2020
@MlgmXyysd MlgmXyysd merged commit 7097267 into master Feb 29, 2020
@MlgmXyysd MlgmXyysd deleted the sepolicy branch February 29, 2020 15:55
@MlgmXyysd MlgmXyysd removed the request for review from solohsu March 1, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants