fix(opentelemetry): correct Span.addEvent 2-arg overload#5929
Merged
Conversation
Fix Span.addEvent to correctly distinguish TimeInput (number, Date, [seconds, nanos]) from Attributes (plain object) when called with 2 arguments. Previously, span.addEvent('name', { foo: 'bar' }) would throw TypeError because attributes were incorrectly treated as TimeInput.
🤖 Generated with Claude Code
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 86ee73b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 tasks
schickling
added a commit
to livestorejs/livestore
that referenced
this pull request
Dec 21, 2025
tim-smart
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Span.addEvent to correctly distinguish TimeInput from Attributes when called with 2 arguments. Previously,
span.addEvent('name', { foo: 'bar' })would throwTypeError: {} is not iterable.Changes
isTimeInputhelper to distinguish between TimeInput (number, Date, or [seconds, nanos] tuple) and Attributes (plain object)addEventoverload resolution to inspect the second argument at runtimeTest Results
All tests pass: 21/21 tests passing in opentelemetry package (14 total, +6 new regression tests for addEvent overloads)