Add templates dir to xochitl.oxide#229
Merged
Eeems merged 1 commit intoEeems-Org:masterfrom Nov 6, 2021
Merged
Conversation
This fixes an issue where xochitl would have trouble loading custom templates when running under Oxide.
Eeems
approved these changes
Nov 6, 2021
Collaborator
|
Thanks! I'll have to put out a small release soon with this included. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where xochitl would have trouble loading custom templates when running under Oxide.
In chat, we discussed that xochitl should probably have access to everything under /usr/share/remarkable, but adding that directory doesn't resolve the bug. It's possible that the correct fix is making the directory permissions recursive, since /usr/share is already present in the list.
However, this does resolve the template issue for me... so may be worth the merge in any case?