Only apply HDF5 shuffle filter when compression is enabled #189
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shuffle filter was being applied based solely on the
H5shuffleflag, without verifying compression was enabled. This added unnecessary overhead whenH5compress=0andH5szip=false.Changes
if (H5compress)toif (H5compress > 0 || H5szip)to support both Deflate and Szip compression modesif (H5compress > 0)if (H5compress > 0 || H5szip)Behavior
Before:
After:
This prevents shuffle overhead when compression is disabled while allowing Szip to be used independently of the H5compress level setting.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.