Conversation
|
I think we can just ditch eslint and let prettier handle reformatting overall. No need for linting anymore unless we want to enforce specific rulesets. |
|
Aside from that LGTM. |
|
I added the travis project since the repo was moved. Coveralls still not updating their cache to let me add from org account so it won't report correctly. |
|
aight let's do this 🚀 |
|
btw, I forgot to reply you on this point
Actually, I would keep linting, since |
Awesome! Once we move to lerna, perhaps an eslint dext plugin would be good. 😀 |
prettiereslintprop-typesNow, I understand that this PR can be really noisy with 2.8K additions, but it's mostly a scroll through PR, except take note of these changes
next up (another PR)
QA
check out this branch, and try out the following
yarn install && yarn lint && yarn build(additional run a prod build)yarn devRunning the commands above, and dext is still up and running (locally at least 😉 )