Skip to content

Conversation

@ajeelias
Copy link
Collaborator

@ajeelias ajeelias commented Nov 1, 2025

📝 Summary

Updates WORKFLOW.md to reflect the new branch protection rules that now require only 1 approval instead of 2, and allows owner/admin bypass.

🔄 Changes Made

Branch Protection Rules Updated

  • Aprobaciones requeridas: 2 → 1
  • Requiere aprobación del último push: Habilitado → Deshabilitado
  • Enforce admins: Habilitado → Deshabilitado (permite bypass)

Documentation Changes

Updated the following sections in WORKFLOW.md:

  1. Branch Protection Rules section

    • Changed required approvals from 2 to 1
    • Updated enforce_admins status
    • Updated require_last_push_approval status
  2. Proceso de Revisión section

    • Updated review process to reflect 1 approval workflow
    • Added note about owner/admin bypass capability
  3. Notas Importantes section

    • Changed from "2 APROBACIONES REQUERIDAS" to "1 APROBACIÓN REQUERIDA"
    • Added "OWNER/ADMIN BYPASS" note
    • Updated stale review note (singular instead of plural)

🎯 Rationale

These changes make the workflow more practical for:

  • Solo development: Owner can review and merge their own PRs if needed
  • Small teams: Only 1 reviewer needed instead of 2
  • Flexibility: Maintains PR discipline while being less restrictive

✅ Protection Still Active

Important protections remain:

  • ✅ No direct push to main (PR required)
  • ✅ Linear history (rebase only)
  • ✅ No force push
  • ✅ No branch deletion
  • ✅ Stale review dismissal on new commits

🧪 Testing This PR

As the owner, I can now:

  1. Approve this PR myself
  2. Merge it with just 1 approval
  3. Or merge it directly using admin bypass

Let's demonstrate! 🚀


🤖 Generated with Claude Code

ajeelias and others added 2 commits November 1, 2025 22:19
Added comprehensive workflow documentation including:
- Branch protection rules configuration
- Pull request creation and review process
- Required 2 approvals workflow
- Common git commands for collaboration
- Team collaboration guidelines

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Changed from 2 to 1 required approval for Pull Requests.

Changes:
- Updated required approvals from 2 to 1
- Documented that owner/admin can bypass approval requirements
- Updated "require last push approval" status (now disabled)
- Updated "enforce admins" status (now disabled for bypass)
- Modified review process section to reflect 1 approval workflow
- Updated important notes with new approval requirements

This change makes the workflow more flexible for solo development
while maintaining pull request discipline and linear history.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@ajeelias ajeelias enabled auto-merge (rebase) November 3, 2025 11:47
@ajeelias ajeelias self-assigned this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants