Removed unnecessary chrome switches #8388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testcafe-need-response-bot
bot
added
the
STATE: Need response
Bayheck
removed
the
STATE: Need response
added 2 commits
March 4, 2025 15:38
…testcafe into default-args-refactored
aleks-pro
approved these changes
Mar 13, 2025
|
Release v3.7.3 addresses this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Remove flags:
'--disable-client-side-phishing-detection', - Removed in HERE
'--disable-infobars', - Removed in HERE
'--password-store=basic',
'--use-mock-keychain',
Tried to remove:
'--enable-automation' (resize tests failed without it)
Approach
Describe how your changes address the issue or implement the desired functionality in as much detail as possible.
References
Closes https://github.com/DevExpress/testcafe-private/issues/549
Pre-Merge TODO