Local gradle pulbish and project refactoring into packages#2
Open
natanieljr wants to merge 6 commits intoDatabaseGroup:masterfrom
Open
Local gradle pulbish and project refactoring into packages#2natanieljr wants to merge 6 commits intoDatabaseGroup:masterfrom
natanieljr wants to merge 6 commits intoDatabaseGroup:masterfrom
Conversation
Collaborator
|
I've commented on the pull request #6. It also contains packaging changes. When we're done with it, I come back here. |
Collaborator
|
Please see the last changes in the master branch and let me know what would be still missing to fix. I think that's only the Maven part. Is that correct? |
Author
|
Yes, All that is missing is the maven plugin to deploy it to a local maven repository. |
Collaborator
|
We're discontinuing this repository. Is this pull request still interesting to resolve? Have a look at our new C++ Tree Similarity library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Nikolaus,
In that commit I did the following changes:
The main benefit of these changes is to improve easiness to use. Currently, to be used in another project, AAPTED JAR has to be copied to a folder and linked to the project as a dependency. With my change, once you deploy it locally, Gradle can handle the dependency management.
Regards,
Nataniel