Skip to content

Conversation

@lucymcnatt
Copy link
Collaborator

@lucymcnatt lucymcnatt commented Nov 19, 2025

Jira ticket: https://broadworkbench.atlassian.net/browse/CTM-142

Dependencies

DataBiosphere/terra-docker#511

Summary of changes

What

Adds a new base image that:

  • enables sudo access for users using custom docker files
  • adds some environment separation
  • included minimal built-in packages for faster development

Why

  • Unblocks custom docker environments
  • Unblocks users adding packages that require sudo

Testing these changes

Tested on a BEE:

  • new base image
  • new base image + GPU
  • new base image + Dataproc
  • older images

What to test

Who tested and where

  • This change is covered by automated tests
    • NB: Rerun automation tests on this PR by commenting jenkins retest or jenkins multi-test.
  • I validated this change
  • Primary reviewer validated this change
  • I validated this change in the dev environment

@lucymcnatt lucymcnatt changed the title [AN-551] New terra base image [CTM-142] New terra base image Dec 1, 2025
@lucymcnatt lucymcnatt requested a review from LizBaldo December 1, 2025 16:29
Copy link
Collaborator

@LizBaldo LizBaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In your testing plan, could you make sure to:

  • Test the new base image with GPUs?
  • Test that the existing images (COS and dataproc) still work with these new startup scripts?

@lucymcnatt lucymcnatt changed the title [CTM-142] New terra base image [CTM-142] New terra base image [DO NOT MERGE] Dec 16, 2025
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.12%. Comparing base (cfaa6a7) to head (5bcce0e).

Files with missing lines Patch % Lines
...tute/dsde/workbench/leonardo/containerModels.scala 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #4888   +/-   ##
========================================
  Coverage    74.12%   74.12%           
========================================
  Files          131      131           
  Lines        11064    11064           
  Branches       882      882           
========================================
  Hits          8201     8201           
  Misses        2863     2863           
Files with missing lines Coverage Δ
...te/dsde/workbench/leonardo/dao/HttpDockerDAO.scala 88.77% <100.00%> (ø)
...rkbench/leonardo/util/BaseRuntimeInterpreter.scala 36.03% <ø> (ø)
...tute/dsde/workbench/leonardo/containerModels.scala 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfaa6a7...5bcce0e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@LizBaldo LizBaldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

If you can add to the PR description the different tests that you did to make sure there were no regression, and that the new base image works with regular CPU and GPU for both COS and Dataproc images that would be awesome.

Excited to 🚢 early next year :)

@lucymcnatt lucymcnatt marked this pull request as ready for review December 17, 2025 16:39
@lucymcnatt lucymcnatt requested a review from a team as a code owner December 17, 2025 16:39
@@ -1,4 +1,5 @@
leonardo {
baseImageUrl = "us.gcr.io/broad-dsp-gcr-public/terra-base:0.0.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're doing semver then the first version shipping publicly to users can be 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants