-
Notifications
You must be signed in to change notification settings - Fork 21
[CTM-142] New terra base image [DO NOT MERGE] #4888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
LizBaldo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In your testing plan, could you make sure to:
- Test the new base image with GPUs?
- Test that the existing images (COS and dataproc) still work with these new startup scripts?
...cala/org/broadinstitute/dsde/workbench/leonardo/monitor/BaseCloudServiceRuntimeMonitor.scala
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4888 +/- ##
========================================
Coverage 74.12% 74.12%
========================================
Files 131 131
Lines 11064 11064
Branches 882 882
========================================
Hits 8201 8201
Misses 2863 2863
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
LizBaldo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
If you can add to the PR description the different tests that you did to make sure there were no regression, and that the new base image works with regular CPU and GPU for both COS and Dataproc images that would be awesome.
Excited to 🚢 early next year :)
| @@ -1,4 +1,5 @@ | |||
| leonardo { | |||
| baseImageUrl = "us.gcr.io/broad-dsp-gcr-public/terra-base:0.0.1" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're doing semver then the first version shipping publicly to users can be 1.0.0
Jira ticket: https://broadworkbench.atlassian.net/browse/CTM-142
Dependencies
DataBiosphere/terra-docker#511
Summary of changes
What
Adds a new base image that:
Why
Testing these changes
Tested on a BEE:
What to test
Who tested and where
jenkins retestorjenkins multi-test.