Fix depth fade tile-shaped artifacts #1704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my machine the depth fade shader sometimes reads out bad values when a polygonOffset shader is used (or if the material system is on). Fix it by calling glTextureBarrier before using a depth fade shader.
slipher
added a commit
to slipher/Daemon
that referenced
this pull request
Aug 5, 2025
Fixes DaemonEngine#1616. Same trick as DaemonEngine#1704 for fixing depth fade.
slipher
added a commit
to slipher/Daemon
that referenced
this pull request
Aug 6, 2025
Fixes DaemonEngine#1616. Same trick as DaemonEngine#1704 for fixing depth fade - insert a texture barrier so that reading the depth texture is valid. Some depth-writing stuff such as polygonOffset decals and alpha-tested textures is rendered after SSAO is done, so in general we need to do the texture barrier twice (if SSAO is on).
slipher
added a commit
that referenced
this pull request
Aug 7, 2025
Fixes #1616. Same trick as #1704 for fixing depth fade - insert a texture barrier so that reading the depth texture is valid. Some depth-writing stuff such as polygonOffset decals and alpha-tested textures is rendered after SSAO is done, so in general we need to do the texture barrier twice (if SSAO is on).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1676.