Closed
Conversation
Member
|
@matjansen Please resolve your conflicts first. Thx. |
Frank-Wiebeler
requested changes
Sep 19, 2018
Member
Frank-Wiebeler
left a comment
Frank-Wiebeler
left a comment
There was a problem hiding this comment.
Technically, that works, thank you for the contribution. :)
But wouldn't it be better to extend the ResponseValidator with a check for that list? .
Could you create an assertResponseStatusIsInRange-Method instead? This way, we would not have so much duplicated code and directly throw the error instead of making a function throw the error by knowing, that it will fail.
Member
|
As we have a new Pull Request for this, I'll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hopefully is a better solution to #20