Open
Conversation
EMREOYUN
reviewed
Jul 2, 2022
Contributor
EMREOYUN
left a comment
EMREOYUN
left a comment
There was a problem hiding this comment.
Is it really required? Yes, you have done an excellent job making the code tidy but I don't think it is necessary. Even you put brackets to the single line of code which you don't need to. It does not break the code but it is unnecessary to add.
My review is neutral.
| $port = 3306; | ||
| if (!isset($port)) { | ||
| $port = 3306; | ||
| } |
Contributor
There was a problem hiding this comment.
Adding brackets into a single line of code is completely unnecessary.
There was a problem hiding this comment.
Adding brackets into a single line of code is completely unnecessary.
Completely agree
| exit("-1"); | ||
| if (empty($_POST['targetAccountID'])) { | ||
| exit("-1"); | ||
| } |
Contributor
There was a problem hiding this comment.
Adding brackets into a single line of code is completely unnecessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.