solve loop issues in most mobile devices which use HTML audio tag#126
Closed
kambing86 wants to merge 1 commit intoCreateJS:masterfrom
Closed
solve loop issues in most mobile devices which use HTML audio tag#126kambing86 wants to merge 1 commit intoCreateJS:masterfrom
kambing86 wants to merge 1 commit intoCreateJS:masterfrom
Conversation
Contributor
|
Hi, after careful consideration I have decided to reject this pull request as per #125. In my testing I have found the current approach to be more robust and reliable. Thank you for taking the time and interest to investigate and create a pull request, I'm really sorry that I won't be accepting it but I hope that won't discourage you from making further requests in the future. If you experience any further issues with looping with the latest release, please reach out here or on Stack Overflow and I will offer any assistance I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refer #125
tested in IE9, Chrome Desktop, Firefox 33 Desktop, iOS8, and a few Android devices, including Galaxy S4, Lenovo S860, and Redmi